Skip to content

Conversation

@jbedard
Copy link
Contributor

@jbedard jbedard commented May 5, 2013

This changes $.fn.val to only call jQuery(this) when it is used (when a function instead of value is passed to .val()).

Also saves a few bytes:
raw gz
-15 -8 dist/jquery.js
-4 -3 dist/jquery.min.js

@dmethvin
Copy link
Member

dmethvin commented May 6, 2013

@jbedard have you signed the CLA? The change itself looks good, always nice to make something smaller and faster.

@jbedard
Copy link
Contributor Author

jbedard commented May 6, 2013

@dmethvin I've now signed the CLA.

@dmethvin
Copy link
Member

dmethvin commented May 6, 2013

It looks like this is now on a minor_changes branch? Do you want to submit all of those at once?

@jbedard
Copy link
Contributor Author

jbedard commented May 6, 2013

I was going to submit those separately, or is one pull request with a few unrelated commits ok?

@dmethvin
Copy link
Member

dmethvin commented May 6, 2013

It just got a bit confusing since the branch has several unrelated commits. I've never seen a pull request that was essentially a cherry-pick of a branch, so it had me a bit confused. 😄 I guess I can pick off the commit from there, let me do that.

@mgol
Copy link
Member

mgol commented May 6, 2013

@jbedard yep, a good advice for the future - always create a separate branch for each pull request and submit the branch, not a single commit. It makes it easy to update pull request if there are any remarks from reviewers (and there often are), you just push a new commit to the branch and the pull request on GitHub is updated automatically.

@jbedard
Copy link
Contributor Author

jbedard commented May 6, 2013

Thanks for the advice, I'll make sure I do that next time. I was intending on creating pull requests for the other changes I have in that branch, I guess I'll put those in their own branches first.

@jbedard
Copy link
Contributor Author

jbedard commented May 7, 2013

I've put this change in it's own branch if you want to use that instead (https://github.com/jbedard/jquery/tree/val_no_jquery). Let me know if that would require a separate pull request.

dmethvin pushed a commit that referenced this pull request May 9, 2013
Conflicts:
	.mailmap
	AUTHORS.txt
@dmethvin dmethvin closed this in c9267ab May 9, 2013
mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants