[chen] - update js2r-rename-var it will enter evil-insert-state #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e start editing var name in spacemacs
NicolasPetton
requested changes
Jun 30, 2019
| @@ -134,6 +134,7 @@ | |||
|
|
|||
| (defun js2r-rename-var () | |||
| "Renames the variable on point and all occurrences in its lexical scope." | |||
| (if (fboundp 'evil-insert-state) (evil-insert-state)) | |||
There was a problem hiding this comment.
I don't know evil, but could you check if we're in evil-mode? It would probably a lot safer, because loading and using evil are two different things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it will switch to evil-insert-state before editing var name in spacemacs or in evil-mode
it do nothing if you are not using evil