Skip to content

Path/improved nodelist functions #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 27, 2024

Conversation

gregsdennis
Copy link
Collaborator

Description

Updates parsing to support nodelist functions as function parameters.

Links

Resolves #836

Checks

Copy link

github-actions bot commented Dec 27, 2024

Test Results

    15 files  ±0      15 suites  ±0   12s ⏱️ -1s
21 509 tests +1  20 524 ✅ +1  985 💤 ±0  0 ❌ ±0 
21 595 runs  +1  20 610 ✅ +1  985 💤 ±0  0 ❌ ±0 

Results for commit 0bb7648. ± Comparison against base commit fd35401.

This pull request removes 25 and adds 7 tests. Note that renamed tests count towards both.
    "bar"
    "bar",
    "baz",
    "foo",
    "other string"
    "quux"
    "string",
    42
  "foo": 42
  "foo": [
…
Json.JsonE.Tests.TruthyTests ‑ IsTruthy([
  42
],True)
Json.JsonE.Tests.TruthyTests ‑ IsTruthy({
  "foo": 42
},True)
Json.Path.Tests.ExpressionTests ‑ ExpressionWithNestedNoOpFunctionWorks
Json.Schema.Tests.CrossDraftTests ‑ ArrayItemsIsAllowedForDraft7({
  "foo": [
    "string",
    "other string"
  ]
},False)
Json.Schema.Tests.CrossDraftTests ‑ ArrayItemsIsAllowedForDraft7({
  "foo": [
    "string",
    42
  ]
},True)
Json.Schema.Tests.LearnJsonEverythingTestFixture ‑ RunCases({
  "instance": "foo",
  "values": [
    "foo",
    "bar"
  ],
  "isValid": false
})
Json.Schema.Tests.LearnJsonEverythingTestFixture ‑ RunCases({
  "instance": "foo",
  "values": [
    "foo",
    "bar",
    "baz",
    "quux"
  ],
  "isValid": true
})
This pull request removes 12 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
    "bar"
    "bar",
    "baz",
    "foo",
    "quux"
  "instance": "foo",
  "isValid": false
  "isValid": true
  "values": [
  ],
…
Json.Schema.Tests.LearnJsonEverythingTestFixture ‑ RunCases({
  "instance": "foo",
  "values": [
    "foo",
    "bar"
  ],
  "isValid": false
})
Json.Schema.Tests.LearnJsonEverythingTestFixture ‑ RunCases({
  "instance": "foo",
  "values": [
    "foo",
    "bar",
    "baz",
    "quux"
  ],
  "isValid": true
})

♻️ This comment has been updated with latest results.

@gregsdennis gregsdennis merged commit 378bbc6 into master Dec 27, 2024
7 checks passed
@gregsdennis gregsdennis deleted the path/improved-nodelist-functions branch December 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONPATH: nesting nodelist function expects working
2 participants