Skip to content

writeOnly missing in draft-07? #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackwootton opened this issue Jul 27, 2019 · 7 comments
Closed

writeOnly missing in draft-07? #770

jackwootton opened this issue Jul 27, 2019 · 7 comments
Assignees
Labels
clarification Items that need to be clarified in the specification

Comments

@jackwootton
Copy link

jackwootton commented Jul 27, 2019

Why is the writeOnly property missing from http://json-schema.org/draft-07/schema?

readOnly is defined:

"readOnly": {
    "type": "boolean",
    "default": false
},

Both readOnly and writeOnly are included in the vocabulary: https://tools.ietf.org/html/draft-handrews-json-schema-validation-01#section-10.3

@Relequestual Relequestual self-assigned this Aug 8, 2019
@Relequestual
Copy link
Member

We will get that fixed! Thanks!

Relequestual added a commit that referenced this issue Aug 15, 2019
@Relequestual
Copy link
Member

Relequestual commented Aug 15, 2019

  • checking out the draft-07 branch of the spec repo, and fixing the problem there with a PR
  • checking out the master branch of the web site repo, updating the draft-07 submodule, and committing that and pushing the result

@Relequestual
Copy link
Member

I comitted directly to the branch rather than making a PR for the draft-7 branch. Oops.
Given it's SUCH a minor change, guess that's OK.
I'll make sure I do a PR for the site... =]

/cc @handrews

@handrews
Copy link
Contributor

@Relequestual all good! Thanks for commenting on it here.

Since it's just a submodule update I don't think you need a PR on the web site repo- I'm not sure that even works. Happy to review one if it does work, but feel free to just push the submodule change if you'd like.

@philsturgeon
Copy link
Collaborator

@Relequestual bump :D

Relequestual added a commit to Relequestual/json-schema-org.github.io that referenced this issue Jan 16, 2020
Update draft-7 submodule for updated metaschema as per json-schema-org/json-schema-spec#770
@Relequestual
Copy link
Member

PR open. 🚢🚢🚢

@handrews
Copy link
Contributor

PR was merged and deployed- thanks, @Relequestual !

@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Bug labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Items that need to be clarified in the specification
Projects
None yet
Development

No branches or pull requests

5 participants