Skip to content

fix: use correct text color on the 404 page in dark mode #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2025
Merged

fix: use correct text color on the 404 page in dark mode #1082

merged 4 commits into from
Apr 30, 2025

Conversation

EGAMAGZ
Copy link
Contributor

@EGAMAGZ EGAMAGZ commented Apr 28, 2025

Fixes #1080

imagen

@EGAMAGZ EGAMAGZ marked this pull request as ready for review April 28, 2025 00:50
crowlKats
crowlKats reviewed Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use text-primary instead, it handles both light and darkmode

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Apr 30, 2025 •
edited
Loading

@crowlKats done, used text-primary instead :D

crowlKats
crowlKats approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@crowlKats crowlKats added this pull request to the merge queue Apr 30, 2025
@crowlKats crowlKats removed this pull request from the merge queue due to a manual request Apr 30, 2025
@crowlKats crowlKats changed the title fix: Assigned text color on dark mode fix: use correct text color on the 404 page in dark mode Apr 30, 2025
@crowlKats crowlKats added this pull request to the merge queue Apr 30, 2025
Merged via the queue into jsr-io:main with commit 9d83fff Apr 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 text does not render correctly in dark mode
2 participants
@EGAMAGZ @crowlKats