Skip to content

feat(scope): add description #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(scope): add description #1093

wants to merge 10 commits into from

Conversation

AugustinMauroy
Copy link
Contributor

close #217

@AugustinMauroy AugustinMauroy changed the title Feat(scope): add description feat(scope): add description May 2, 2025
crowlKats
crowlKats requested changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of it being nullable, always only support a string, and check for empty string instead as the description not being set (just like we do for package description).

AugustinMauroy
AugustinMauroy commented May 3, 2025
View reviewed changes
api/src/api.yml Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO(@AugustinMauroy): update this when pr is cleaned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to add a description field to a scope
2 participants
@AugustinMauroy @crowlKats