Skip to content

fix: specify the color-scheme for dark mode #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LitoMore
Copy link
Contributor

@LitoMore LitoMore commented May 5, 2025

PR Checklist

  • The PR title follows
    conventional commits
  • Is this closing an open issue? If so, link it, else include a proper
    description of the changes and rason behind them.
  • Does the PR have changes to the frontend? If so, include screenshots or a
    recording of the changes.

    If it affect colors, please include screenshots/recording in both
    light and dark mode.
  • Does the PR have changes to the backend? If so, make sure tests are added.

    And if changing dababase queries, be sure you have ran sqlx prepare
    and committed the changes in the .sqlx directory.

How to reproduce this issue

(Safari does not support this, you need to use Chrome or Firefox to reproduce this issue)

  1. Switch to dark mode
  2. Modify any img src to https://cdn.simpleicons.org/jsr/yellow/blue in your inspector
  3. The image color should be blue, but it's yellow on production

Description

The package readme may include a dynamic color scheme style in the image, like this project's readme: https://github.com/LitoMore/simple-icons-cdn.

This PR fixes a display behavior when the remote image has a prefers-color-scheme inside for dark mode.

Preview

Before After

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants