fix: specify the color-scheme for dark mode #1100
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
conventional commits
description of the changes and rason behind them.
recording of the changes.
If it affect colors, please include screenshots/recording in both
light and dark mode.
And if changing dababase queries, be sure you have ran
sqlx prepare
and committed the changes in the
.sqlx
directory.How to reproduce this issue
(Safari does not support this, you need to use Chrome or Firefox to reproduce this issue)
https://cdn.simpleicons.org/jsr/yellow/blue
in your inspectorDescription
The package readme may include a dynamic color scheme style in the image, like this project's readme: https://github.com/LitoMore/simple-icons-cdn.
This PR fixes a display behavior when the remote image has a
prefers-color-scheme
inside for dark mode.Preview