-
Notifications
You must be signed in to change notification settings - Fork 5.2k
add event for finished execution of cell #2061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, @dkrenn! Looks like this PR was made against the wrong branch. Can you update the base to |
@minrk Set to master. (Bckporting was not meant by me; simply I wanted to show only correct diff, i.e. the changes that I made branching from 4.3.1. Now the PR is crowed again...) |
I think you'll need to make the commits again starting from a recent commit on master (or copy them using |
@takluyver Sure, this will work (even merging in master on my branch should work). However, there are (as far as I have checked) no merge conflicts at all, so a from a git-workflow-perspective, no need to do such a thing as merge master in or rebase it on master. Not sure, what Github's problem is with this. |
Ok, I see the problem now: Your master builds up on 4.1.0, whereas my branch builds up on 4.3.1. This explains now all the merging issues. |
We do 4.x (for instance) releases from master until we merge something which we only want to go into 5.0. At that point, we create a |
bf0a732
to
e3bdb15
Compare
@takluyver Thanks for the clarification. I cherry-picked now. Looks much better now :) |
Thanks. This looks OK to me now. We'll leave it a while for other people to take a look, and merge if there are no objections. |
We will need this for instrumentation. jupyter/notebook#2061
closes #2060
At the moment, there are is no event that signals the completion of the evaluation/execution of a code cell (FYI, there is one, if the execution starts). The aim is to implement such an event.