Skip to content

add event for finished execution of cell #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 25, 2017

Conversation

dkrenn
Copy link
Contributor

@dkrenn dkrenn commented Jan 23, 2017

closes #2060

At the moment, there are is no event that signals the completion of the evaluation/execution of a code cell (FYI, there is one, if the execution starts). The aim is to implement such an event.

@dkrenn dkrenn changed the title add event for finished execution of cell #2060 add event for finished execution of cell Jan 23, 2017
@dkrenn dkrenn changed the base branch from master to 4.x January 23, 2017 07:22
@minrk
Copy link
Member

minrk commented Jan 24, 2017

Thanks, @dkrenn! Looks like this PR was made against the wrong branch. Can you update the base to :master? All PRs should be made against master, and we can consider backporting after merge if necessary.

@dkrenn dkrenn changed the base branch from 4.x to master January 24, 2017 11:19
@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 24, 2017

@minrk Set to master. (Bckporting was not meant by me; simply I wanted to show only correct diff, i.e. the changes that I made branching from 4.3.1. Now the PR is crowed again...)

@takluyver
Copy link
Member

I think you'll need to make the commits again starting from a recent commit on master (or copy them using git cherry-pick if you're comfortable doing that). Because you made the commits on top of the 4.x branch, targetting the PR to master doesn't work.

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 24, 2017

@takluyver Sure, this will work (even merging in master on my branch should work). However, there are (as far as I have checked) no merge conflicts at all, so a from a git-workflow-perspective, no need to do such a thing as merge master in or rebase it on master. Not sure, what Github's problem is with this.
Branch-update follows...

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 24, 2017

Ok, I see the problem now: Your master builds up on 4.1.0, whereas my branch builds up on 4.3.1. This explains now all the merging issues.

@takluyver
Copy link
Member

We do 4.x (for instance) releases from master until we merge something which we only want to go into 5.0. At that point, we create a 4.x branch for further releases, and backport changes into it. In this case, that happened after 4.1.

@dkrenn dkrenn force-pushed the dkrenn/event-finished-exec branch from bf0a732 to e3bdb15 Compare January 24, 2017 12:18
@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 24, 2017

@takluyver Thanks for the clarification. I cherry-picked now. Looks much better now :)

@minrk minrk added this to the 5.0 milestone Jan 24, 2017
@takluyver
Copy link
Member

Thanks. This looks OK to me now. We'll leave it a while for other people to take a look, and merge if there are no objections.

@minrk minrk merged commit cd47dac into jupyter:master Jan 25, 2017
jeffyjefflabs added a commit to nbgallery/jupyter-alpine that referenced this pull request Feb 1, 2017
We will need this for instrumentation.

jupyter/notebook#2061
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add event for finished execution of cell
4 participants