followup #450: fixes behavior when "disableBranchWithChanges": true
#477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
requested changes
Dec 4, 2019
There was a problem hiding this comment.
@telamonian One minor change regarding conditional logic to ensure that empty arrays do not return a false positive.
Co-Authored-By: Athan <[email protected]>
kgryte
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
The most recent changes look good to me and should cover the potential cases where stagedFiles and unstagedFiles could be either
undefinednull[][ 'path1', 'path2', ... ]
and we only want to disable branch operations when we either have staged or unstaged files (i.e., when either unstagedFiles or stagedFiles is a non-empty Array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup #450
Currently, if
"disableBranchWithChanges": trueis in settings, branch ops are disabled completely in all cases. This PR restores the old "disable when there are changes" behavior when the setting istrue