Added forms component unit test cases examples #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juristr
reviewed
Oct 15, 2019
|
|
||
| it('name field validity', () => { | ||
| let errors = {}; | ||
| let name = component.form.controls['name']; |
There was a problem hiding this comment.
I'd use component.form.get('name') rather than going over the .controls['name']. That's usually the way you access form controls on reactive Angular forms. Could you change this in the test?
There was a problem hiding this comment.
Yeah sure. Updated it using get method usage. Thanks!
|
@shant24k awesome, thanks for your work and sorry this isn’t going faster. I’m currently travelling (just about to start from San Francisco back home). So I’ll try to catch up with this later, ok. Meanwhile thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit test cases examples of
@juristr Please review & suggest any changes required.