Skip to content

Fix array attributes parsing in project save (create / update) #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kbsali merged 6 commits into from
Jan 28, 2015
Merged

Fix array attributes parsing in project save (create / update) #87

kbsali merged 6 commits into from
Jan 28, 2015

Conversation

@alxshr
Copy link
Contributor

@alxshr alxshr commented Oct 19, 2014

No description provided.

@alxshr alxshr changed the title Fix tracker_ids parsing in update Fix array attributes parsing in project save (create / update) Oct 19, 2014
@kbsali
Copy link
Owner

kbsali commented Nov 5, 2014

@alxshr please make sure to follow the coding style (i see tabs and missed-placed braces, etc...),
and more importantly, run phpunit before issuing the pull request : it is failing!
thanks

JanMalte
JanMalte reviewed Nov 26, 2014
View reviewed changes
lib/Redmine/Api/Issue.php Outdated
Copy link
Contributor

@JanMalte JanMalte Nov 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the debug lines completely. No debug code should be in the production code.

@alxshr
Copy link
Contributor Author

alxshr commented Nov 26, 2014

Fixed.

@kbsali
Copy link
Owner

kbsali commented Nov 26, 2014

don't forget the coding style in general (braces + tabs).

@alxshr
Copy link
Contributor Author

alxshr commented Nov 26, 2014

Hi,
Where can I find the coding style rules? I am using the default Zend Studio formatting...

@kbsali
Copy link
Owner

kbsali commented Nov 26, 2014

it is based on http://symfony.com/doc/current/contributing/code/standards.html
try running php-cs-fixer, it should fix pretty much all the issues.

@alxshr
Copy link
Contributor Author

alxshr commented Dec 4, 2014

Fixed code formatting by php-cs-fixer

@alxshr
Copy link
Contributor Author

alxshr commented Jan 6, 2015

Any news on this?

@Henry31
Copy link

Henry31 commented Jan 28, 2015

The fixed Tracker_ids are awesome! Good work! :)

@kbsali kbsali mentioned this pull request Jan 28, 2015
Closed
kbsali added a commit that referenced this pull request Jan 28, 2015
@kbsali
Merge pull request #87 from alxshr/master
7110d59 
Fix array attributes parsing in project save (create / update)
@kbsali kbsali merged commit 7110d59 into kbsali:master Jan 28, 2015
@kbsali
Copy link
Owner

kbsali commented Jan 28, 2015

thx @alxshr , sorry for being so slow in merging your PR.
There are a couple more details i would like to change, but i'll do it myself!

Could you please provide an example for this? (and better even, some tests!)

@kbsali kbsali mentioned this pull request Feb 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alxshr @kbsali @Henry31 @JanMalte