allow to set custom service instance id #51
Merged
+76
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for setting a custom service instance ID in the Laravel OpenTelemetry package. The service instance ID is an important OpenTelemetry attribute that helps distinguish between different instances of the same service.
- Introduces a new configuration option
service_instance_idthat can be set via environment variableOTEL_SERVICE_INSTANCE_ID - Refactors resource building logic into a dedicated
ResourceBuilderclass for better organization - Updates the service provider to use the new resource builder and fixes a deprecated constant reference
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| config/opentelemetry.php | Adds new service_instance_id configuration option |
| src/Support/ResourceBuilder.php | New class to handle OpenTelemetry resource building with service attributes |
| src/LaravelOpenTelemetryServiceProvider.php | Refactored to use ResourceBuilder and fixed deprecated constant usage |
| tests/Sdk/ServiceTest.php | Added tests for service resource attributes and custom instance ID functionality |
| phpstan-baseline.neon | Updated baseline to handle new deprecation warnings |
| README.md | Updated documentation to include the new service_instance_id configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.