Skip to content

Move generate compilation to the task model #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 21, 2023
Merged

Move generate compilation to the task model #804

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
11fd312
Move compilation to the task model
mattdangerw Mar 1, 2023
56772b0
Fix beam search for new interface
mattdangerw Mar 7, 2023
277f95e
Fix tests and docstrings
mattdangerw Mar 10, 2023
4a82d88
Minor fixups
mattdangerw Mar 10, 2023
9d8124e
Remove from_logits; clarify logits vs probabilities
mattdangerw Mar 10, 2023
4e60829
Readability fixes
mattdangerw Mar 10, 2023
d885a00
Minor fixes
mattdangerw Mar 10, 2023
9c843f8
Fix test failures
mattdangerw Mar 11, 2023
6685327
Address comments
mattdangerw Mar 17, 2023
6304f13
Address comments
mattdangerw Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor fixes
  • Loading branch information
@mattdangerw
mattdangerw committed Mar 10, 2023
commit d885a009a4801d965a5dea57e9490240922e6162
2 changes: 1 addition & 1 deletion keras_nlp/models/gpt2/gpt2_causal_lm_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def test_gpt2_causal_lm_fit_no_preprocessing(self, jit_compile):
@parameterized.named_parameters(
("jit_compile_false", False), ("jit_compile_true", True)
)
def test_compilation(self, jit_compile):
def test_generate(self, jit_compile):
# Tensor input.
self.causal_lm.compile(jit_compile=jit_compile)
self.causal_lm.generate(
Expand Down
2 changes: 1 addition & 1 deletion keras_nlp/samplers/beam_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ def __call__(
self,
next,
prompt,
index=0,
state=None,
index=0,
mask=None,
end_token_id=None,
):
Expand Down