Skip to content

Conversation

lasselehtinen
Copy link
Contributor

The current getEpubVersion returns only int, which is unsufficient for our use when we would need to the exact ePub version number (2.0.1, 3.0, 3.3 and so on). Instead of changing the current functionality, I added a new getEpubVersionString method to OPF parser which returns the full version as string.

@ewilan-riviere
Copy link
Contributor

Excellent idea, thanks for this PR!

@ewilan-riviere ewilan-riviere self-assigned this Jun 30, 2025
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.34%. Comparing base (18997c1) to head (f7c29fa).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #110      +/-   ##
============================================
+ Coverage     90.33%   90.34%   +0.01%     
- Complexity      833      834       +1     
============================================
  Files            32       32              
  Lines          2577     2580       +3     
============================================
+ Hits           2328     2331       +3     
  Misses          249      249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ewilan-riviere ewilan-riviere merged commit 3d5852c into kiwilan:main Jun 30, 2025
10 checks passed
@ewilan-riviere ewilan-riviere mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants