Skip to content

Conversation

ewilan-riviere
Copy link
Contributor

  • Upgrade kiwilan/php-archive
  • Improve error logging if an archive is invalid with Laravel illuminate/support (optional and if installed) otherwise use error_log()
  • Add saveTo() method to EbookCover class
public function saveTo(string $path): bool

- Improve error logging if an archive is invalid with Laravel `illuminate/support` (optional and if installed) otherwise use `error_log()`
- Add `saveTo()` method to `EbookCover` class

```php
public function saveTo(string $path): bool
```
@ewilan-riviere ewilan-riviere self-assigned this Aug 31, 2025
Copy link

codecov bot commented Aug 31, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.04%. Comparing base (ccaf1ff) to head (8b18e39).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/Ebook.php 92.85% 1 Missing ⚠️
src/EbookCover.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #122      +/-   ##
============================================
- Coverage     90.05%   90.04%   -0.01%     
- Complexity      845      849       +4     
============================================
  Files            32       32              
  Lines          2593     2611      +18     
============================================
+ Hits           2335     2351      +16     
- Misses          258      260       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ewilan-riviere ewilan-riviere merged commit ddc5223 into main Aug 31, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant