Skip to content

Claim Adjacency List and Radix Tree #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
May 6, 2016
Merged

Conversation

scalls
Copy link
Contributor

@scalls scalls commented Apr 12, 2016

Hi,

I am working in the group project that JFTung mentioned in pull request #102. I had not created the directories and linked them to the master README, so my "claims" were not included. I created a directory for both Adjacency List and Radix Tree, linked them to the master README, and created a placeholder README file in those directories.

@hollance
Copy link
Member

I know what an Adjacency List is in the context of a graph, but I didn't know about a separate data structure called ad adjacency list. What does this do?

@scalls
Copy link
Contributor Author

scalls commented Apr 13, 2016

I think that is a typo, I'm not sure what an ad adjacency list is either.

EDIT: If you meant "an adjacency list", I want to create a graph data structure stored in an adjacency list.

@hollance
Copy link
Member

Ah ok. Note that we already have that inside Graph. Improvements are always welcome of course. :-)

@scalls
Copy link
Contributor Author

scalls commented Apr 26, 2016

Hi,

Just wanted to check in again. I have scrapped my work on the Adjacency List data structure and decided to focus my efforts on creating the Radix Tree. I have implemented most functionality and have updated the README significantly.

@hollance
Copy link
Member

Cool. Make sure you give credit to the creator of the image, per the license.

@hollance
Copy link
Member

hollance commented May 2, 2016

Is this done now? If yes, then I'll merge it and do my customary edit (where necessary).

@scalls
Copy link
Contributor Author

scalls commented May 3, 2016

Yes, go ahead and merge

@hollance hollance merged commit a2f4de8 into kodecocodes:master May 6, 2016
@hollance
Copy link
Member

hollance commented May 6, 2016

OK, I've made some tweaks.

Some remarks:

  • The code seems quite complex. It would be useful if you explain how the important operations work in the README.
  • I removed some stuff from the README. It read more like an API reference than an explanation of how the algorithm actually works, but explaining how it works is the purpose of this project.
  • We're not using Swift 3 yet. ;-) I guess you're on Linux so you have no other choice but I had to change the code back to Swift 2.x for now.
  • I added your name to the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants