Tweak eslint rules #594
Merged
Tweak eslint rules #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason to have this turned off; we don't violate the rule anywhere and I don't think I've ever worked on a codebase that did violate it tbh
Maybe in an old version of eslint, these disabled on-by-default rules, but there ARE no on-by-default rules in the latest version of eslint, so these lines have no effect. Seems like deleting them all simplifies the config.
…console.log lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixes some minor things I spotted in #593; see individual commit messages for explanations. This is NOT an attempt to fully rethink the eslint config and go for an optimal ruleset for 2025, just an attempt to improve specific things I spotted and thought seemed wrong.