feat: adding support for excluding labels in csp and ksp for endpoint matching #1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prateeknandle
force-pushed
the
excluding-labels
branch
from
df06c68 to
a752b3b
Compare
daemon1024
previously requested changes
Mar 17, 2025
Member
daemon1024
left a comment
daemon1024
left a comment
There was a problem hiding this comment.
New set of tests for KSP
matchExpressions
- label In,NotIn
One more test case
where both of them exist? (Need an answer to this)
Prateeknandle
force-pushed
the
excluding-labels
branch
6 times, most recently
from
04972c8 to
b8487d3
Compare
Prateeknandle
force-pushed
the
excluding-labels
branch
4 times, most recently
from
c655a86 to
987970b
Compare
rksharma95
reviewed
Apr 1, 2025
Prateeknandle
force-pushed
the
excluding-labels
branch
from
987970b to
966ab02
Compare
rksharma95
approved these changes
Apr 2, 2025
Collaborator
rksharma95
left a comment
rksharma95
left a comment
There was a problem hiding this comment.
LGTM 👍
waiting for CI to pass.
@Prateeknandle please update the branch.
Prateeknandle
force-pushed
the
excluding-labels
branch
from
966ab02 to
c11489d
Compare
anurag-rajawat
approved these changes
Apr 4, 2025
rksharma95
force-pushed
the
excluding-labels
branch
from
c11489d to
0401fc0
Compare
… matching Signed-off-by: Prateek <[email protected]>
Aryan-sharma11
force-pushed
the
excluding-labels
branch
from
0401fc0 to
8d49938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Support for adding condition for selecting workloads in the policies (ksp & csp) under
matchExpressions.Fixes #
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>