Skip to content

Conversation

@FernandoPazCavalcante
Copy link
Contributor

@FernandoPazCavalcante FernandoPazCavalcante commented Sep 22, 2025

Purpose of PR?: Parameterize deployments resources configuration for KubeArmor HelmChart

Fixes #

Does this PR introduce a breaking change?
no

If the changes in this PR are manually verified, list down the scenarios covered::
I've been using this helm chart for some months and then it suddenly crashed my AWS EC2 instance due to exceed memory usage. There were a lack of setup at my side, but some kind of memory limit should be available to be set up in this helm chart.

Additional information for reviewer? :
Added resources parameterization in values.yaml with default request value
edit: added resources property in kubearmorController and kubearmorRelay deployments.

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@rksharma95
Copy link
Collaborator

@FernandoPazCavalcante thanks for the PR, default deployment method is kubearmor-operator can we handle it there as well?

@AlissonRS
Copy link

@FernandoPazCavalcante I'd also recommend adding resources to the daemonset.

@FernandoPazCavalcante
Copy link
Contributor Author

@FernandoPazCavalcante thanks for the PR, default deployment method is kubearmor-operator can we handle it there as well?

The kubearmor-operator already has this resource management property but it was missing in kubearmor helm chart. I also added it to the DaemonSet as requested by @AlissonRS

@AlissonRS
Copy link

@rksharma95 do you think this PR is good enough for merging, based on @FernandoPazCavalcante's comment above?

@rksharma95
Copy link
Collaborator

@AlissonRS @FernandoPazCavalcante it's fine If kubearmor helm chart being used for deployment.
when kubearmor-operator being used for deployment, the resource configuration present with operator helm chart will deploy kubearmor-operator with this resource limits, but it will not be passed to other deployments, daemonset. as operator generates and deploy k8s resource i.e. deployment, daemonset, etc as part of it.

let me know if this meets your requirements in that case we can definitely merge this PR. thanks again for the PR @FernandoPazCavalcante 🙌

@FernandoPazCavalcante
Copy link
Contributor Author

@AlissonRS @FernandoPazCavalcante it's fine If kubearmor helm chart being used for deployment. when kubearmor-operator being used for deployment, the resource configuration present with operator helm chart will deploy kubearmor-operator with this resource limits, but it will not be passed to other deployments, daemonset. as operator generates and deploy k8s resource i.e. deployment, daemonset, etc as part of it.

let me know if this meets your requirements in that case we can definitely merge this PR. thanks again for the PR @FernandoPazCavalcante 🙌

Yes, these changes definitely meet our needs since I need to define resource requests and limits, and this is the chart we use in my team. Thank you very much. 🙏

@rksharma95
Copy link
Collaborator

Yes, these changes definitely meet our needs since I need to define resource requests and limits, and this is the chart we use in my team. Thank you very much. 🙏

Thanks for update, We can start review, will merge after then. thanks again for the PR

Copy link
Collaborator

@rksharma95 rksharma95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AryanBakliwal AryanBakliwal merged commit bc0f080 into kubearmor:main Dec 23, 2025
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants