-
Notifications
You must be signed in to change notification settings - Fork 419
fix(KubeArmor helm): added resources property in values.yaml file #2192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@FernandoPazCavalcante thanks for the PR, default deployment method is |
|
@FernandoPazCavalcante I'd also recommend adding |
The |
|
@rksharma95 do you think this PR is good enough for merging, based on @FernandoPazCavalcante's comment above? |
|
@AlissonRS @FernandoPazCavalcante it's fine If kubearmor helm chart being used for deployment. let me know if this meets your requirements in that case we can definitely merge this PR. thanks again for the PR @FernandoPazCavalcante 🙌 |
Yes, these changes definitely meet our needs since I need to define resource requests and limits, and this is the chart we use in my team. Thank you very much. 🙏 |
Thanks for update, We can start review, will merge after then. thanks again for the PR |
rksharma95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Signed-off-by: Fernando Paz Silva Cavalcante <[email protected]>
Signed-off-by: Fernando Paz Silva Cavalcante <[email protected]>
Signed-off-by: Fernando Paz Silva Cavalcante <[email protected]>
Purpose of PR?: Parameterize deployments resources configuration for KubeArmor HelmChart
Fixes #
Does this PR introduce a breaking change?
no
If the changes in this PR are manually verified, list down the scenarios covered::
I've been using this helm chart for some months and then it suddenly crashed my AWS EC2 instance due to exceed memory usage. There were a lack of setup at my side, but some kind of memory limit should be available to be set up in this helm chart.
Additional information for reviewer? :
Added resources parameterization in values.yaml with default
requestvalueedit: added resources property in kubearmorController and kubearmorRelay deployments.
Checklist:
<type>(<scope>): <subject>