-
Notifications
You must be signed in to change notification settings - Fork 419
feat: add EventData field to KubeArmor telemetry #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add EventData field to KubeArmor telemetry #2204
Conversation
|
|
@Ishaanj18 thank for the PR, can you provide the json output for process and network events as well? also please sign-off the commits before push. thanks 🙌 |
|
|
@Ishaanj18 for network events the |
|
@Ishaanj18 wdyt if we just combine the structure data for both |
c57216d to
12783bf
Compare
|
I think naming correctly itself can make the objective more clearer even if we keep 2 separate field. |
|
Using grpc: |
AryanBakliwal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please rebase and squash the commits @Ishaanj18
8cad69b to
276a999
Compare
276a999 to
88ba27e
Compare
"EventData": {
"domain": "AF_UNIX",
"protocol": "HOPOPT",
"syscall": "SYS_SOCKET",
"type": "SOCK_STREAM|SOCK_NONBLOCK|SOCK_CLOEXEC"
},@Ishaanj18 let's use consistent formatting: "EventData": {
"Domain": "AF_UNIX",
"Protocol": "HOPOPT",
"Syscall": "SYS_SOCKET",
"Type": "SOCK_STREAM|SOCK_NONBLOCK|SOCK_CLOEXEC"
}, |
Signed-off-by: ishaanj18 <[email protected]>
88ba27e to
aa076a4
Compare
|
|
Updated formatting @rksharma95 |
This provides clients with structured key-value access while preserving the original string format for backward compatibility.
Purpose of PR?:
Fixes #2173
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>