Skip to content

Preserve CustomDiskSize checkbox value and fields on Edit Machine Deployment #7415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Preserve CustomDiskSize checkbox value and fields on Edit Machine Deployment #7415

merged 1 commit into from
Jun 10, 2025

Conversation

KhizerRehan
Copy link
Contributor

@KhizerRehan KhizerRehan commented Jun 10, 2025 •
edited
Loading

What this PR does / why we need it:
This PR fixes to preserve "Custom Disk" checkbox in Edit Machine Deployment Dialog and display DiskSize field.

a569a2717b47349c8faed398fb92c4f7.mp4

Which issue(s) this PR fixes:

Fixes #7281

What type of PR is this?
/kind bug

Special notes for your reviewer:
Checks presence of diskSize in case of "Custom Disk" option is selected

Does this PR introduce a user-facing change? Then add your Release Note here:

Shows custom disk fields when a custom disk is configured in the Machine Deployment edit dialog.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2025
@KhizerRehan KhizerRehan requested a review from Waseem826 June 10, 2025 13:31
Waseem826
Waseem826 approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@Waseem826 Waseem826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2025
@Waseem826
Copy link
Contributor

/hold
To be merged after 2.28

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2025
@Waseem826
Copy link
Contributor

/retest

@ahmedwaleedmalik ahmedwaleedmalik added this to the KKP 2.29 milestone Jun 10, 2025
ahmedwaleedmalik
ahmedwaleedmalik requested changes Jun 10, 2025
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhizerRehan all the bug fixes that are supposed to be backported should have an accompanying release note. Please add a release note for this PR.

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2025
@kubermatic-bot kubermatic-bot requested a review from Waseem826 June 10, 2025 15:34
@ahmedwaleedmalik ahmedwaleedmalik added the backport-needed Denotes a PR or issue that has not been fully backported. label Jun 10, 2025
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 10, 2025
@ahmedwaleedmalik
Copy link
Member

/retest

@ahmedwaleedmalik
Copy link
Member

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2025
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0943c8f9f55e64dd4797e950817072cd41446eb5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmedwaleedmalik
Copy link
Member

/cherry-pick release/v2.27

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v2.27 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v2.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahmedwaleedmalik
Copy link
Member

/cherry-pick release/v2.26

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v2.26 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahmedwaleedmalik
Copy link
Member

/cherry-pick release/v2.25

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v2.25 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahmedwaleedmalik ahmedwaleedmalik modified the milestones: KKP 2.29, KKP 2.28 Jun 10, 2025
@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Jun 10, 2025
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Jun 10, 2025
@kubermatic-bot kubermatic-bot merged commit 17de9f0 into kubermatic:main Jun 10, 2025
10 checks passed
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #7417

In response to this:

/cherry-pick release/v2.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Jun 10, 2025
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #7418

In response to this:

/cherry-pick release/v2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Jun 10, 2025
Merged
@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #7419

In response to this:

/cherry-pick release/v2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Jun 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@Waseem826 Waseem826 Awaiting requested review from Waseem826

Assignees

@Waseem826 Waseem826

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-needed Denotes a PR or issue that has not been fully backported. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.28
Development

Successfully merging this pull request may close these issues.

"Custom Disk" setting is not preserved on the edit MachineDeployment dialogue when not enforced
4 participants
@KhizerRehan @Waseem826 @ahmedwaleedmalik @kubermatic-bot