Skip to content

Fix Dex fails in dashboard-api-e2e test #7416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix Dex fails in dashboard-api-e2e test #7416

wants to merge 3 commits into from

Conversation

mohamed-rafraf
Copy link
Member

What this PR does / why we need it:

This PR updates the dex values to pass the dashboard-api-e2e-tests successfully
Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 10, 2025
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign waseem826 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. sig/api Denotes a PR or issue as being assigned to SIG API. labels Jun 10, 2025
@mohamed-rafraf
Copy link
Member Author

/assign
/miletone KKP 2.28

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 10, 2025
@mohamed-rafraf mohamed-rafraf force-pushed the fix-e2e branch 3 times, most recently from 92e50c2 to 9e0cb17 Compare June 10, 2025 15:16
@mohamed-rafraf
fix dex fail in dashboard-api e2e tests
cf1c4fd 
update

update

update

update

update

update

update

update

add ingress spec

add ingress spec
@kubermatic-bot
Copy link
Contributor

@mohamed-rafraf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-dashboard-api-e2e ae715ea link true /test pre-dashboard-api-e2e

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ahmedwaleedmalik
Copy link
Member

Fixed in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mohamed-rafraf mohamed-rafraf

Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. release-note-none Denotes a PR that doesn't merit a release note. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohamed-rafraf @kubermatic-bot @ahmedwaleedmalik