Skip to content

Allow manual installation of system applications except with type cni #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Waseem826
Copy link
Contributor

What this PR does / why we need it:
This PR adds functionality to allow manually installing system applications except with type cni. This is useful especially for installing cluster autoscaler application after cluster creation.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature
Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Allow manual installation of system applications except with type `cni`.

Documentation:

NONE

@Waseem826 Waseem826 added this to the KKP 2.28 milestone Jun 11, 2025
@Waseem826 Waseem826 self-assigned this Jun 11, 2025
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2025
@Waseem826
Copy link
Contributor Author

/retest

@Waseem826 Waseem826 changed the title Allow manual installation system applications except with type cni Allow manual installation of system applications except with type cni Jun 11, 2025
@ahmadhamzh ahmadhamzh self-requested a review June 11, 2025 16:49
Copy link
Contributor

@ahmadhamzh ahmadhamzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 52e9ba806ee57882e7c4198cf073f1ef7417c490

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmadhamzh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2025
@Waseem826 Waseem826 added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Jun 11, 2025
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Jun 11, 2025
@kubermatic-bot kubermatic-bot merged commit 3bcafb3 into kubermatic:main Jun 11, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants