Skip to content

feat: allow to set the cwd in copyToPod for use in tar #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2023
Merged

feat: allow to set the cwd in copyToPod for use in tar #989

merged 2 commits into from
Feb 16, 2023

Conversation

SayakMukhopadhyay
Copy link

This PR fixes #987

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2023
@SayakMukhopadhyay SayakMukhopadhyay marked this pull request as ready for review February 15, 2023 08:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2023
@brendandburns
Copy link
Contributor

This looks fine, but CI/CD hasn't been run for some reason. I'm going to close and re-open to try to trigger it.

/ok-to-test

@brendandburns brendandburns reopened this Feb 16, 2023
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, SayakMukhopadhyay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit d3ed6dd into kubernetes-client:master Feb 16, 2023
@SayakMukhopadhyay SayakMukhopadhyay deleted the fix-987 branch February 16, 2023 18:03
@leahjlou
Copy link

Hi @brendandburns, do you have an idea of when there will be a new release available on NPM? I'm interested in using the code in this commit in something I'm working on. Thank you!

@SayakMukhopadhyay SayakMukhopadhyay mentioned this pull request Jan 22, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@drubin drubin Awaiting requested review from drubin

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set the working directory while copying
5 participants
@SayakMukhopadhyay @brendandburns @k8s-ci-robot @leahjlou @clintonmedbery