Skip to content

Add CSI driver for Google Cloud Storage to list #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2020
Merged

Add CSI driver for Google Cloud Storage to list #273

merged 2 commits into from
Feb 19, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 5, 2020

This documents a driver for mounting Google Cloud Storage buckets https://github.com/ofek/csi-gcs

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 5, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @ofek!

It looks like this is your first PR to kubernetes-csi/docs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/docs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2020
@ofek
Copy link
Contributor Author

ofek commented Feb 5, 2020

/assign @msau42

@ofek
Copy link
Contributor Author

ofek commented Feb 6, 2020

Hello! Is there anything else I need to do here?

msau42
msau42 reviewed Feb 7, 2020
View reviewed changes
book/src/drivers.md Outdated
@@ -31,6 +31,7 @@ Name | CSI Driver Name | Compatible with CSI Version(s) | Description | Persiste
[Ember CSI](https://ember-csi.io) | `[x].ember-csi.io` | v0.2, v0.3, v1.0 | Multi-vendor CSI plugin supporting over 80 Drivers to provide block and mount storage to Container Orchestration systems. | Persistent | Read/Write Single Pod | Yes | Raw Block, Snapshot
[GCE Persistent Disk](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver) | `pd.csi.storage.gke.io` | v0.3, v1.0 | A Container Storage Interface (CSI) Driver for Google Compute Engine Persistent Disk (GCE PD) | Persistent | Read/Write Single Pod | Yes | Snapshot
[Google Cloud Filestore](https://github.com/kubernetes-sigs/gcp-filestore-csi-driver) | `com.google.csi.filestore` | v0.3 | A Container Storage Interface (CSI) Driver for Google Cloud Filestore | Persistent | Read/Write Multiple Pods | Yes |
[Google Cloud Storage](https://github.com/ofek/csi-gcs) | `storage.csi.cloud.google.com` | v1.0 | A Container Storage Interface (CSI) Driver for Google Cloud Storage | Persistent | Read/Write Multiple Pods | No |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and work on the driver!

Since this driver is not maintained or supported by Google, can you replace "cloud.google.com" in the driver name with your own personal domain? And also add a note to the repo that it is not an officially supported Google product.

@ofek
Copy link
Contributor Author

ofek commented Feb 14, 2020

@msau42 Thanks, I renamed the driver!

@ofek
Copy link
Contributor Author

ofek commented Feb 14, 2020

I added the note: https://github.com/ofek/csi-gcs#disclaimer

@ofek
Copy link
Contributor Author

ofek commented Feb 14, 2020

@msau42 Does this look alright to you now?

@msau42
Copy link
Collaborator

msau42 commented Feb 19, 2020

/lgtm
/approve
/release-note-none

Thank you!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, ofek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 49beac1 into kubernetes-csi:master Feb 19, 2020
@ofek ofek deleted the gcs branch February 19, 2020 03:29
@ofek ofek mentioned this pull request Apr 18, 2020
Merged
@maennchen maennchen mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @k8s-ci-robot @msau42