Skip to content

Fix release-staging cloudbuild job - hopefully #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix release-staging cloudbuild job - hopefully
Signed-off-by: Nick Young <[email protected]>
  • Loading branch information
Nick Young committed Mar 15, 2022
commit b4bd15d81a92a63295ba0eea0350dd21160dcb52
5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ export BASE_REF ?= master
# The commit hash of the current checkout
# Used to pass a binary version for master,
# overridden to semver for tagged versions.
export COMMIT=$(shell git rev-parse --short HEAD)
# Cloudbuild will set this in the environment to the
# commit SHA, since the Prow does not seem to check out
# a git repo.
export COMMIT ?= $(shell git rev-parse --short HEAD)

DOCKER ?= docker
# TOP is the current directory where this Makefile lives.
Expand Down
3 changes: 3 additions & 0 deletions cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ steps:
- DOCKER_CLI_EXPERIMENTAL=enabled
- GIT_TAG=$_GIT_TAG
- BASE_REF=$_PULL_BASE_REF
- COMMIT=$_PULL_BASE_SHA
args:
- release-staging
substitutions:
Expand All @@ -22,3 +23,5 @@ substitutions:
# _PULL_BASE_REF will contain the ref that was pushed to to trigger this build -
# a branch like 'master' or 'release-0.2', or a tag like 'v0.2'.
_PULL_BASE_REF: 'master'
# _PULL_BASE_SHA will contain the Git SHA of the commit that was pushed to trigger this build.
_PULL_BASE_SHA: 'abcdef'