-
Notifications
You must be signed in to change notification settings - Fork 35
Add further checks on Module version #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add further checks on Module version #457
Conversation
Prevent updating to or from an empty ModuleLoader version, as this requires recreating new DaemonSets because of labelSelector updates
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qbarrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
+ Coverage 82.89% 83.05% +0.16%
==========================================
Files 33 33
Lines 3315 3329 +14
==========================================
+ Hits 2748 2765 +17
+ Misses 464 462 -2
+ Partials 103 102 -1
☔ View full report in Codecov by Sentry. |
modulelog.Info("Validating Module update", "name", m.Name, "namespace", m.Namespace) | ||
|
||
if old != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can old be nil in the ValidateUpdate? It will mean that the old object does not exists, and in that case ValidateCreate should have been called, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it should never be nil. However I have not dug into the implementation and I would not fail if old
is nil but there is a legitimate reason that we have not thought about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, fair enough.
/hold |
/lgtm |
/unhold |
This PR allows customer to run Preflight validation flow on an OCP cluster with RT kernel deployed. The flow as following 1) add a boolean flag to PreflightOCP CR that allows user to specify if he wants to validate for Full kernel version or for RT kernel version 2) when extracting the OS configuration from the OCP DTK image, in case boolean flag in CR was set, the validation kernel is set to RT kernel
…s-sigs#642) Prevent updating to or from an empty ModuleLoader version, as this requires recreating new DaemonSets because of labelSelector updates Upstream-Commit: 4b3bc41 Co-authored-by: Quentin Barrand <[email protected]>
Prevent updating to or from an empty ModuleLoader version, as this requires recreating new DaemonSets because of labelSelector updates.
/cc @yevgeny-shnaidman