Adding NotFound error to the GetMLD API #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/S
|
/test pull-kernel-module-management-unit-tests |
qbarrand
reviewed
Aug 3, 2023
internal/utils/errors.go
Outdated
|
|
||
| import "errors" | ||
|
|
||
| var ErrNotFound = errors.New("not found") |
There was a problem hiding this comment.
I would make this ErrNoMatchingKernelMapping and move it to the internal/module package where it is used.
In case kernel mapping for the kernel version is not found, GetModuleLoaderDataForKernel API returns an indistinguishable error, just like in case there was some internal error during processing. This PR introducing a new propriaetory error: ErrNotFound. In case kernel mapping for a specific kernel does not exists, this error will be returned. As a consequence, the calling code will be able to act seperatly on internal error, or on KernelMapping not present, which may not be an error at all
yevgeny-shnaidman
force-pushed
the
yevgeny/err-not-found-mld
branch
from
45d50d4 to
7cb49f4
Compare
for the upcoming module-nmc controller |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
qbarrand
pushed a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Nov 8, 2023
…etes-sigs#689) In case kernel mapping for the kernel version is not found, GetModuleLoaderDataForKernel API returns an indistinguishable error, just like in case there was some internal error during processing. This PR introducing a new propriaetory error: ErrNotFound. In case kernel mapping for a specific kernel does not exists, this error will be returned. As a consequence, the calling code will be able to act seperatly on internal error, or on KernelMapping not present, which may not be an error at all Upstream-Commit: bb43458 Co-authored-by: Yevgeny Shnaidman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case kernel mapping for the kernel version is not found, GetModuleLoaderDataForKernel API returns an indistinguishable error, just like in case there was some internal error during processing.
This PR introducing a new propriaetory error: ErrNotFound. In case kernel mapping for a specific kernel does not exists, this error will be returned. As a consequence, the calling code will be able to act seperatly on internal error, or on KernelMapping not present, which may not be an error at all