Replacing Jobs with Pods in the building/signing features. #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
approved
|
@yevgeny-shnaidman @qbarrand @mresvanis Do you think we should also rename the job packages? |
qbarrand
reviewed
Aug 6, 2023
qbarrand
reviewed
Aug 6, 2023
ybettan
force-pushed
the
jobs-to-pods
branch
2 times, most recently
from
7f85166 to
c163c64
Compare
yes, otherwise it is confusing. We should rename job package under build and sign, and rename the "jobhelper" file to "podhelper" |
qbarrand
reviewed
Aug 7, 2023
ybettan
force-pushed
the
jobs-to-pods
branch
2 times, most recently
from
0c1a25d to
c432517
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
- Coverage 81.58% 81.48% -0.11%
==========================================
Files 42 42
Lines 3758 3748 -10
==========================================
- Hits 3066 3054 -12
- Misses 564 566 +2
Partials 128 128
☔ View full report in Codecov by Sentry. |
ybettan
force-pushed
the
jobs-to-pods
branch
2 times, most recently
from
33d5519 to
0048bba
Compare
Done. |
ybettan
force-pushed
the
jobs-to-pods
branch
4 times, most recently
from
6fc4379 to
6cb7ee7
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
We are not using any of the Job's features and we are reconciling the operator artifacts (jobs/pods) anyway, so it is better to reconcile pods directly. Signed-off-by: Yoni Bettan <[email protected]>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
qbarrand
added a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Nov 8, 2023
…netes-sigs#504) This PR add the following 3 labels, that will be used during ordered update process: 1) kmm.node.kubernetes.io/version-label-module_<namespace>_<name> 2) kmm.node.kubernetes.io/version-label-module-loader_<namespace>_<name> 3) kmm.node.kubernetes.io/version-label-device-plugin_<namespace>_<name> The first label is set by the user and signifies on which node which version should be run. The second and the third labels are managed by KMMO and are used as node selectors for module loader and device plugin damoensets accordingly. This PR also include utils functions for generating the full labels' names and for extracting namespace and name data from labels Upstream-Commit: a5ebe9b Co-authored-by: Yevgeny Shnaidman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not using any of the Job's features and we are reconciling the operator artifacts (jobs/pods) anyway, so it is better to reconcile pods directly.
Fixes #465