In case NMC does not exists, Get should return NotFound error #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #510 +/- ##
==========================================
- Coverage 81.18% 81.18% -0.01%
==========================================
Files 42 42
Lines 3896 3895 -1
==========================================
- Hits 3163 3162 -1
Misses 601 601
Partials 132 132
☔ View full report in Codecov by Sentry. |
|
/test pull-kernel-module-management-unit-tests |
1 similar comment
|
/test pull-kernel-module-management-unit-tests |
qbarrand
pushed a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Nov 8, 2023
Bumps openshift/origin-cli from 4.13 to 4.14. --- updated-dependencies: - dependency-name: openshift/origin-cli dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
qbarrand
pushed a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.