Update ordered upgrade docs for v2 #657
Merged
+31
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qbarrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
=======================================
Coverage 78.83% 78.83%
=======================================
Files 49 49
Lines 5102 5102
=======================================
Hits 4022 4022
Misses 892 892
Partials 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| `beta.kmm.node.kubernetes.io/version-worker-pod.<module-namespace>.<module-name>` label, which removes the entry from | ||
| the corresponding `NodeModulesConfig` resource. | ||
| This results in a worker Pod being created to unload the current kernel module. | ||
| 4. Once the current kernel module is unloaded Pod is removed, the controller sets the |
There was a problem hiding this comment.
Suggested change
| 4. Once the current kernel module is unloaded Pod is removed, the controller sets the | |
| 4. Once the current kernel module is unloaded, the controller sets the |
qbarrand
force-pushed
the
v2-docs-ordered-upgrade
branch
from
5522fb7 to
f2cd6a0
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
qbarrand
added a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Jan 8, 2024
…sigs#919) Upstream-Commit: 1488a62 Co-authored-by: Quentin Barrand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #655
/cc @yevgeny-shnaidman