-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore: upgrade golangci-lint to 2.1.6 #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This issue is currently awaiting triage. If metrics-server contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
paths: | ||
- third_party$ | ||
- builtin$ | ||
- examples$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was updated running the command golangci-lint migrate
as mentioned in https://golangci-lint.run/product/migration-guide/
44b39d7
to
82d01f4
Compare
Signed-off-by: Jayapriya Pai <[email protected]>
Seems we met some failing checks need to be resolved:
|
// CumulativeCpuUsed is the cumulative cpu used at Timestamp from the StartTime of container/node. Unit: nano core * seconds. | ||
CumulativeCpuUsed uint64 | ||
// CumulativeCPUUsed is the cumulative cpu used at Timestamp from the StartTime of container/node. Unit: nano core * seconds. | ||
CumulativeCPUUsed uint64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are updated as per lint checks but I wanted to check with @dgrisonnet if this is ok and mention as change in changelog or we want to continue old name itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is ok, metrics-server is not meant to be used as a library
Signed-off-by: Jayapriya Pai <[email protected]>
/assign @dgrisonnet @RainbowMango |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Upgrade golangci-lint to 2.1.16
https://golangci-lint.run/product/migration-guide
I believe this could fix the verify test that gets hang currently
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #