Skip to content

chore: upgrade golangci-lint to 2.1.6 #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

slashpai
Copy link
Member

@slashpai slashpai commented May 9, 2025

What this PR does / why we need it:

Upgrade golangci-lint to 2.1.16
https://golangci-lint.run/product/migration-guide

I believe this could fix the verify test that gets hang currently

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot requested a review from serathius May 9, 2025 12:33
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 9, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If metrics-server contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2025
paths:
- third_party$
- builtin$
- examples$
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was updated running the command golangci-lint migrate as mentioned in https://golangci-lint.run/product/migration-guide/

@slashpai
Copy link
Member Author

cc @dgrisonnet @RainbowMango

@slashpai slashpai force-pushed the fix-verify branch 4 times, most recently from 44b39d7 to 82d01f4 Compare June 17, 2025 02:20
@RainbowMango
Copy link
Member

Seems we met some failing checks need to be resolved:

func parseContainerCpuMetrics(namespaceName apitypes.NamespacedName, containerName string, timestamp int64, value float64, pods map[apitypes.NamespacedName]storage.PodMetricsPoint) {
     ^
pkg/storage/storage_benchmark_test.go:235:2: ST1003: struct field cumulativeCpuUsed should be cumulativeCPUUsed (staticcheck)
	cumulativeCpuUsed uint64
	^
pkg/storage/types.go:48:2: ST1003: struct field CumulativeCpuUsed should be CumulativeCPUUsed (staticcheck)
	CumulativeCpuUsed uint64
	^
test/e2e_test.go:378:2: ST1003: var reqUrl should be reqURL (staticcheck)
	reqUrl := url.URL{Scheme: scheme, Path: path, RawQuery: query, Host: fmt.Sprintf("127.0.0.1:%d", localPort)}
	^

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2025
// CumulativeCpuUsed is the cumulative cpu used at Timestamp from the StartTime of container/node. Unit: nano core * seconds.
CumulativeCpuUsed uint64
// CumulativeCPUUsed is the cumulative cpu used at Timestamp from the StartTime of container/node. Unit: nano core * seconds.
CumulativeCPUUsed uint64
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are updated as per lint checks but I wanted to check with @dgrisonnet if this is ok and mention as change in changelog or we want to continue old name itself

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is ok, metrics-server is not meant to be used as a library

@slashpai slashpai mentioned this pull request Jun 5, 2025
2 tasks
Signed-off-by: Jayapriya Pai <[email protected]>
@slashpai
Copy link
Member Author

/assign @dgrisonnet @RainbowMango

@dgrisonnet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2112ed6 into kubernetes-sigs:master Jun 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants