-
Notifications
You must be signed in to change notification settings - Fork 4.7k
pvc nfs example : add "volumeName" to nfs-pvc to connect it to nfs-pv #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Welcome @matanw! |
|
/lgtm |
|
@matanw you'll have to sing the CLA though. |
|
I signed it |
|
I add a redundant "i", fixed, pls re- lgtm |
idvoretskyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: idvoretskyi, matanw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
it is very weird that there is no connection between nfs-pv and nfs-pvc
Where I copy this example it works, but when I used it with multiple PVs and PVVs, this is not working -PVC is bounded to a random PVC
I wondering if adding "volumeName" to PVC is enough or we need also add claimRef to PV