Migrate k8s-infra-prow-builds to cgroups v2

[BenTheElder]

We'll probably want to coordinate with test-infra-oncall to do this for the existing default cluster as well.

https://cloud.google.com/kubernetes-engine/docs/how-to/node-system-config#cgroup-mode-options

cgroups v2 is the future and eventually when kubernetes etc stops supporting v1 then we will need this to run things like KIND and local-up-cluster.sh

[BenTheElder]

We should also check what the EKS cluster is doing.

[bobbypage]

/cc

[BenTheElder]

Quick hacky test:

kubectl run --rm -it --privileged --env DOCKER_IN_DOCKER_ENABLED=true --image=gcr.io/k8s-staging-test-infra/krte:v20230421-ec4335b54b-master test -- sh -c 'curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.18.0/kind-$(uname)-amd64" && chmod +x ./kind && ./kind create cluster; ./kind delete cluster'
If you don't see a command prompt, try pressing enter.
wrapper.sh] [SETUP] Done setting up Docker in Docker.
fatal: not a git repository (or any of the parent directories): .git
================================================================================
wrapper.sh] [TEST] Running Test Command: `sh -c curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.18.0/kind-$(uname)-amd64" && chmod +x ./kind && ./kind create cluster; ./kind delete cluster` ...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    97  100    97    0     0    487      0 --:--:-- --:--:-- --:--:--   487
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 6808k  100 6808k    0     0  10.8M      0 --:--:-- --:--:-- --:--:-- 10.8M
Creating cluster "kind" ...
 ✓ Ensuring node image (kindest/node:v1.26.3) 🖼 
 ✓ Preparing nodes 📦  
 ✓ Writing configuration 📜 
 ✓ Starting control-plane 🕹️ 
 ✓ Installing CNI 🔌 
 ✓ Installing StorageClass 💾 
Set kubectl context to "kind-kind"
You can now use your cluster with:

kubectl cluster-info --context kind-kind

Have a question, bug, or feature request? Let us know! https://kind.sigs.k8s.io/#community 🙂
Deleting cluster "kind" ...
Deleted nodes: ["kind-control-plane"]
wrapper.sh] [TEST] Test Command exit code: 0
wrapper.sh] [CLEANUP] Cleaning up after Docker in Docker ...
Stopping Docker: docker.
wrapper.sh] [CLEANUP] Done cleaning up after Docker in Docker.
================================================================================
wrapper.sh] Exiting 0
Session ended, resume using 'kubectl attach test -c test -i -t' command when the pod is running
pod "test" deleted

KIND at the latest release is working fine with our e2e docker-in-docker on cgroups v2 GKE host (v1.26 node pool in a new test cluster, double checked that v2 is detected).

[xmudrii]

/cc
for EKS cluster

[ameukam]

IIUC, adding a new nodepool with GKE 1.26+ should give us cgroupv2 by default. prow-build got upgraded to 1.26. Maybe add a new nodepool ?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xmudrii]

Still relevant kubernetes/test-infra#31572
/remove-lifecycle stale

[ameukam]

/sig k8s-infra
/sig testing
/priority backlog
/area infra

[ameukam]

/assign @BenTheElder

[xmudrii]

It appears that the EKS Prow build cluster is already using cgroups v2. Here are some references:

• Bottlerocket 1.13.0 moving to cgroup v2 for new variants bottlerocket-os/bottlerocket#2874
• EKS [request]: Support cgroup v2 aws/containers-roadmap#1953 (comment)

I did some checks as well:

$ mount | grep cgroup
cgroup2 on /sys/fs/cgroup type cgroup2 (rw,nosuid,nodev,noexec,relatime,seclabel)

$ stat -f -c %T /sys/fs/cgroup/
cgroup2fs

@BenTheElder @ameukam Is there anything else that we should check?

[ameukam]

I don't think there is something else to be check. Let's wait on Ben's input.

[BenTheElder]

KIND jobs will need to be migrated to cover both and we'll need to figure out how/when we want to flip this bit on our assorted GKE clusters. Not sure on that and have been mostly focused on getting all the infra running under community accounts at the moment, but we should really be discussing this with kubernetes/enhancements#4572

[BenTheElder]

I think this is just going to work, but we have to consider that hack/local-up-cluster.sh and KIND style coverage for any projects using them will suddenly be v2 and not v1 anymore.

In the KIND project we have some github actions aimed at ensuring we get coverage for both (... because this is a kernel / boot time option and on prow we'd have to spin up external VMs ... we may have to move that to prow anyhow as the future of macOS with virt support on github actions seems unclear)

... other projects / CI jobs have implicitly been testing on v1

[BenTheElder]

We should probably at least send an FYI to [email protected] when we flip the switch

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[BenTheElder]

WARNING: Node pool pool5-20210928124956061000000001 is running cgroupv1 which is deprecated. Please use cgroupv2 instead. For additional details, please refer to https://cloud.google.com/kubernetes-engine/docs/how-to/migrate-cgroupv2

FYI @stmcginnis @aojea: kind on prow will wind up being cgroup v2 only at some point, we'll need to invert and make sure GHA VMs are covering cgroup v1 when this happens

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.