-
Notifications
You must be signed in to change notification settings - Fork 27
feat(ubuntu): Add Ubuntu 25.04 #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It adds the latest Ubuntu release 25.04 (Plucky Puffin) which will be supported from April 2025 until January 2026. Signed-off-by: polarctos <[email protected]>
Reviewer's Guide by SourceryThis pull request adds support for Ubuntu 25.04 (Plucky Puffin) to the static registry, including artifacts for x86_64, aarch64, and s390x architectures. This allows users to run the latest Ubuntu release within kubevirt. Updated class diagram for the static registryclassDiagram
class Entry {
Artifacts: []Artifact
UseForDocs: bool
}
class Artifact {
// Assuming Artifact is an interface or abstract class
}
class Ubuntu {
+New(version string, arch string, env map[string]string) Artifact
}
Entry --|> Artifact : contains
Ubuntu --|> Artifact : implements
note for Entry "Entry now includes Ubuntu 25.04"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Hi @polarctos. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @polarctos - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why
UseForDocs
is set to false for the new Ubuntu version.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Looking at 24.10 the only way I think we could do this if we introduce some kind of limited retention policy for these images to reduce the number we are carrying at one time. I know we looked into this through quay itself in the past but we could also just implement the same directly in the project. @codingben @jcanocan @0xFelix thoughts? |
What would be the idea? Maybe to introduce a new field for non-LTS with a due to date or something similar? |
That or the number of old versions to keep or just a plain |
There were plans to add a purge mechanism to the containerdisk tool in the past already. It's not in the scope of this PR but eventually we need a mechanism like that. |
Can't we enable "prune image tags by creation date"? There is an open issue to discuss it: #101. |
I wasn't aware of such a mechanism. But maybe it will be a good mid-term solution. |
@codingben The feature as a whole needs to be groomed a little further. Expiring images only by creation date might lead to removal of all disks in a repository which we don't want. |
Looking at the previous short term support version of Ubuntu 24.10, over the total lifetime there were just 13 actual released image versions. So this is maybe actually not that many. For the Ubuntu 25.04 added in this PR there are currently 2 released image versions. Would it be possible to have this Ubuntu version added and then a general purge mechanism be designed separately? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine to me!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
This adds the latest Ubuntu release
25.04
(Plucky Puffin) which will be supported from April 2025 until January 2026.Version
25.04
is not a LTS release so it could be debated if it necessary to include it.However one of the nice benefits of kubevirt compared to containers in Kubernetes is the possibility to run newer Linux kernels, thus having access to current releases as a trusted published containerdisk is very useful.
At a current point in the time there would be up to 5 Ubuntu versions in standard support, 3 LTS releases and up to 2 current releases: https://ubuntu.com/about/release-cycle or https://endoflife.date/ubuntu
So the noise of a still very well manageable number of current Ubuntu versions is still acceptable from my perspective.
As another example the Docker official images for Ubuntu also have the non-LTS releases during their standard support window, thus 5 versions there too: https://hub.docker.com/_/ubuntu/
When the support window for this non-LTS version ends, it can just be replaced by the next successor version. As the old tags remain in the quay.io registry there is no risk of breaking configs as the old versions can still be referenced, they just don't receive updates anymore then.
Release note: