Skip to content

feat(ubuntu): Add Ubuntu 25.04 #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Conversation

polarctos
Copy link
Contributor

What this PR does / why we need it:

This adds the latest Ubuntu release 25.04 (Plucky Puffin) which will be supported from April 2025 until January 2026.

Version 25.04 is not a LTS release so it could be debated if it necessary to include it.
However one of the nice benefits of kubevirt compared to containers in Kubernetes is the possibility to run newer Linux kernels, thus having access to current releases as a trusted published containerdisk is very useful.

At a current point in the time there would be up to 5 Ubuntu versions in standard support, 3 LTS releases and up to 2 current releases: https://ubuntu.com/about/release-cycle or https://endoflife.date/ubuntu
So the noise of a still very well manageable number of current Ubuntu versions is still acceptable from my perspective.

As another example the Docker official images for Ubuntu also have the non-LTS releases during their standard support window, thus 5 versions there too: https://hub.docker.com/_/ubuntu/

When the support window for this non-LTS version ends, it can just be replaced by the next successor version. As the old tags remain in the quay.io registry there is no risk of breaking configs as the old versions can still be referenced, they just don't receive updates anymore then.

Release note:

Added support for Ubuntu 25.04 (Plucky Puffin)

It adds the latest Ubuntu release 25.04 (Plucky Puffin) which will be supported from April 2025 until January 2026.

Signed-off-by: polarctos <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 24, 2025
Copy link

sourcery-ai bot commented Apr 24, 2025

Reviewer's Guide by Sourcery

This pull request adds support for Ubuntu 25.04 (Plucky Puffin) to the static registry, including artifacts for x86_64, aarch64, and s390x architectures. This allows users to run the latest Ubuntu release within kubevirt.

Updated class diagram for the static registry

classDiagram
  class Entry {
    Artifacts: []Artifact
    UseForDocs: bool
  }
  class Artifact {
    // Assuming Artifact is an interface or abstract class
  }
  class Ubuntu {
    +New(version string, arch string, env map[string]string) Artifact
  }

  Entry --|> Artifact : contains
  Ubuntu --|> Artifact : implements

  note for Entry "Entry now includes Ubuntu 25.04"
Loading

File-Level Changes

Change Details Files
Added support for Ubuntu 25.04 (Plucky Puffin) for x86_64, aarch64, and s390x architectures.
  • Added a new entry to the static registry for Ubuntu 25.04.
  • Created artifacts for x86_64, aarch64, and s390x architectures with default environment variables.
cmd/medius/common/registry.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@kubevirt-bot
Copy link
Contributor

Hi @polarctos. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @polarctos - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why UseForDocs is set to false for the new Ubuntu version.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lyarwood
Copy link
Member

This adds the latest Ubuntu release 25.04 (Plucky Puffin) which will be supported from April 2025 until January 2026.

Looking at 24.10 the only way I think we could do this if we introduce some kind of limited retention policy for these images to reduce the number we are carrying at one time. I know we looked into this through quay itself in the past but we could also just implement the same directly in the project.

@codingben @jcanocan @0xFelix thoughts?

@jcanocan
Copy link
Contributor

This adds the latest Ubuntu release 25.04 (Plucky Puffin) which will be supported from April 2025 until January 2026.

Looking at 24.10 the only way I think we could do this if we introduce some kind of limited retention policy for these images to reduce the number we are carrying at one time. I know we looked into this through quay itself in the past but we could also just implement the same directly in the project.

@codingben @jcanocan @0xFelix thoughts?

What would be the idea? Maybe to introduce a new field for non-LTS with a due to date or something similar?

@lyarwood
Copy link
Member

This adds the latest Ubuntu release 25.04 (Plucky Puffin) which will be supported from April 2025 until January 2026.

Looking at 24.10 the only way I think we could do this if we introduce some kind of limited retention policy for these images to reduce the number we are carrying at one time. I know we looked into this through quay itself in the past but we could also just implement the same directly in the project.
@codingben @jcanocan @0xFelix thoughts?

What would be the idea? Maybe to introduce a new field for non-LTS with a due to date or something similar?

That or the number of old versions to keep or just a plain bool to only keep the latest.

@0xFelix
Copy link
Member

0xFelix commented Apr 25, 2025

There were plans to add a purge mechanism to the containerdisk tool in the past already. It's not in the scope of this PR but eventually we need a mechanism like that.

@codingben
Copy link
Member

This adds the latest Ubuntu release 25.04 (Plucky Puffin) which will be supported from April 2025 until January 2026.

Looking at 24.10 the only way I think we could do this if we introduce some kind of limited retention policy for these images to reduce the number we are carrying at one time. I know we looked into this through quay itself in the past but we could also just implement the same directly in the project.

@codingben @jcanocan @0xFelix thoughts?

Can't we enable "prune image tags by creation date"? There is an open issue to discuss it: #101.

@jcanocan
Copy link
Contributor

This adds the latest Ubuntu release 25.04 (Plucky Puffin) which will be supported from April 2025 until January 2026.

Looking at 24.10 the only way I think we could do this if we introduce some kind of limited retention policy for these images to reduce the number we are carrying at one time. I know we looked into this through quay itself in the past but we could also just implement the same directly in the project.
@codingben @jcanocan @0xFelix thoughts?

Can't we enable "prune image tags by creation date"? There is an open issue to discuss it: #101.

I wasn't aware of such a mechanism. But maybe it will be a good mid-term solution.

@0xFelix
Copy link
Member

0xFelix commented Apr 28, 2025

@codingben The feature as a whole needs to be groomed a little further. Expiring images only by creation date might lead to removal of all disks in a repository which we don't want.

@polarctos
Copy link
Contributor Author

polarctos commented May 14, 2025

Looking at the previous short term support version of Ubuntu 24.10, over the total lifetime there were just 13 actual released image versions. So this is maybe actually not that many. For the Ubuntu 25.04 added in this PR there are currently 2 released image versions.

Would it be possible to have this Ubuntu version added and then a general purge mechanism be designed separately?

Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine to me!

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@jcanocan
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@kubevirt-bot kubevirt-bot merged commit 8977714 into kubevirt:main May 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants