Skip to content

Add golint to ci #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2019
Merged

Add golint to ci #1243

merged 3 commits into from
Jan 9, 2019

Conversation

cappyzawa
Copy link

@cappyzawa cappyzawa commented Dec 30, 2018

I enable to run golint in ci.
And I fixed based on golint.
Before: Job #2330.1 - labstack/echo - Travis CI
After: Job #2331.1 - labstack/echo - Travis CI

@cappyzawa cappyzawa changed the title WIP: Add golint to ci Add golint to ci Dec 30, 2018
@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #1243 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1243   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files          26       26           
  Lines        1927     1927           
=======================================
  Hits         1572     1572           
  Misses        248      248           
  Partials      107      107
Impacted Files Coverage Δ
echo.go 87.63% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8b45c...4480d8b. Read the comment docs.

@vishr vishr merged commit e6ac002 into labstack:master Jan 9, 2019
@cappyzawa cappyzawa deleted the fix/lint branch January 10, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants