Enable adding preload tag to HSTS header
#1247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1247 +/- ##
==========================================
+ Coverage 84.22% 84.23% +0.01%
==========================================
Files 26 26
Lines 1952 1954 +2
==========================================
+ Hits 1644 1646 +2
Misses 202 202
Partials 106 106
Continue to review full report at Codecov.
|
vishr
approved these changes
Mar 6, 2019
|
@hchood Could you please resolve the conflict? |
hchood
force-pushed
the
enable-hsts-preload
branch
from
22a9859 to
9336ce7
Compare
|
Done. Thanks for reviewing @vishr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1248
We would like our domain to be listed on Chrome's HSTS preload list, which requires that the
preloadtag be appended to the HSTS header like so, and as described here: