Quote regex meta characters in Rewrite #1541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is a half and half situation where the user can't use regex (fully) because * will be replaced with (.*), yet they also can't just enter any old string, because meta chars like . would need escaping. e.g. currently *.html wouldn't work as intended, and instead *\.html should be used. Work around this by using regexp's QuoteMeta function to sanitise the input before handling it.
Codecov Report
@@ Coverage Diff @@
## master #1541 +/- ##
=======================================
Coverage 84.84% 84.85%
=======================================
Files 28 28
Lines 2165 2166 +1
=======================================
+ Hits 1837 1838 +1
Misses 213 213
Partials 115 115
Continue to review full report at Codecov.
|
vishr
approved these changes
Mar 29, 2020
This was referenced Jun 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a half and half situation where the user can't use regex (fully) because
*will be replaced with(.*), yet they also can't just enter any old string, because meta chars like.would need escaping.e.g. currently
*.htmlwouldn't work as intended, and instead*\.htmlshould be used.Work around this by using regexp's
QuoteMetafunction to sanitise the input before handling it.This is a breaking change, since if someone is already working-around the bug by manually escaping stuff, their escapes would be escaped!