-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fixed Router#Find panic an infinite loop #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Router#Find panic an infinite loop #1661
Conversation
Before this fix, Router#Find panics or enters in an infinite loop when the context params values were set to a number less than the max number of params supported by the Router.
Codecov Report
@@ Coverage Diff @@
## master #1661 +/- ##
==========================================
+ Coverage 85.19% 85.26% +0.06%
==========================================
Files 29 29
Lines 1986 1995 +9
==========================================
+ Hits 1692 1701 +9
Misses 186 186
Partials 108 108
Continue to review full report at Codecov.
|
Good done! I am looking forward to this being merged. |
@pafuent Please rebase, I'll merge then. |
Referencing #1689 as it might be related. |
@lammel rebased |
@lammel @pafuent there is something wrong with this merge. I do not understand why Line 503 in ea31edb
these are changes between last working merge to master and current master 4422e3b...master and something went wrong with 4422e3b...0482cb3 |
This seems to be problem for these tests f72eaa4#diff-996f64128c7fffe6cc8254ea4e1ac3c5693956f86ab5c8952e525083cf14ca27L26 but Line 503 in ea31edb
is also strange. |
@aldas Please check my comment here #1674 (comment) |
Before this fix, Router#Find panics or enters in an infinite loop when the context params values were set to a number less than the max number of params supported by the Router.
This fix #1655