Fix Static files route not working #1671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1671 +/- ##
=======================================
Coverage 85.19% 85.20%
=======================================
Files 29 29
Lines 1986 1987 +1
=======================================
+ Hits 1692 1693 +1
Misses 186 186
Partials 108 108
Continue to review full report at Codecov.
|
pafuent
approved these changes
Nov 7, 2020
|
can you merge? to avoid incoming conflict |
|
Thanks for your contribution!!! |
|
Due to an open issue with a trailing slash the PR needs to be resubmitted @pwli0755 . Sorry for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix 404 error when using Static files route Echo.Static()
related issue