Skip to content

issue #1729 - Binding query/path params and form fields to struct only works for explicit tags #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2021
Merged

issue #1729 - Binding query/path params and form fields to struct only works for explicit tags #1734

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7efda20
Binding query/path params and form fields to struct only works for fi…
aldas Dec 20, 2020
254d08c
remove unnecessary benchmark after change because it is not valid tes…
aldas Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove unnecessary benchmark after change because it is not valid tes… 
…t anymore
  • Loading branch information
@aldas
aldas committed Jan 5, 2021
commit 254d08c4c73f82035a90f7af93272e0c64f4a8ae
14 changes: 0 additions & 14 deletions bind_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,20 +515,6 @@ func TestBindSetFields(t *testing.T) {
}
}

func BenchmarkBindbindData(b *testing.B) {
b.ReportAllocs()
assert := assert.New(b)
ts := new(bindTestStruct)
binder := new(DefaultBinder)
var err error
b.ResetTimer()
for i := 0; i < b.N; i++ {
err = binder.bindData(ts, values, "form")
}
assert.NoError(err)
assertBindTestStruct(assert, ts)
}

func BenchmarkBindbindDataWithTags(b *testing.B) {
b.ReportAllocs()
assert := assert.New(b)
Expand Down