Skip to content

improve code quality #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2021
Merged

improve code quality #1792

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e026656
Merge variable declaration with assignment
withshubh Feb 25, 2021
27af642
Fix unnecessary typecasting on `bytes.Buffer`
withshubh Feb 25, 2021
f25e77f
Remove unnecessary wrapping of function call
withshubh Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unnecessary typecasting on bytes.Buffer
  • Loading branch information
@withshubh
withshubh committed Feb 25, 2021
commit 27af642656ca2129b209c3ca2d9d58aa5b672dbb
2 changes: 1 addition & 1 deletion middleware/logger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func TestLoggerCustomTimestamp(t *testing.T) {
e.ServeHTTP(rec, req)

var objs map[string]*json.RawMessage
if err := json.Unmarshal([]byte(buf.String()), &objs); err != nil {
if err := json.Unmarshal(buf.Bytes(), &objs); err != nil {
panic(err)
}
loggedTime := *(*string)(unsafe.Pointer(objs["time"]))
Expand Down