Skip to content

fix(DefaultHTTPErrorHandler): return error message when message is an error #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2023
Merged

fix(DefaultHTTPErrorHandler): return error message when message is an error #2456

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94f9c21
fix(DefaultHTTPErrorHandler): return error message when message is an…
gnuletik May 26, 2023
321c93e
fix(echo): marshal as JSON for types that implements json.Marshaler
gnuletik May 28, 2023
f133ab6
test(DefaultHTTPErroHandler): refactor to table based test
gnuletik May 28, 2023
e7e0db9
fix(DefaultHTTPErrorHandler): remove useless break statement in switc…
gnuletik May 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(DefaultHTTPErrorHandler): remove useless break statement in switc… 
…h case
  • Loading branch information
@gnuletik
gnuletik committed May 28, 2023
commit e7e0db90f4a4e6db4e10fc9deb9705e1561b7e3c
1 change: 0 additions & 1 deletion echo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,6 @@ func (e *Echo) DefaultHTTPErrorHandler(err error, c Context) {
}
case json.Marshaler:
// do nothing - this type knows how to format itself to JSON
break
case error:
message = Map{"message": m.Error()}
}
Expand Down