[12.x] Adds checking if a value is between two columns

[DarkGhostHunter]

What?

This PR allows the developer to check if a given value is between two columns. This complements both whereBetween() whereColumnsBetween() methods, as these can't check if a value (like an integer or timestamp) is between two columns. It's left to the developer to properly cast the values or column values as with the prior methods.

This avoids using raw statements with the danger of SQL Injections, but Raw statements are accepted as values and columns too. Yes, it also gets rid of using double WHERE clauses for the same purpose.

use App\Models\Post;

// Before
Post::whereRaw('? between "visible_from" and "visible_to"', now())->get();
Post::where('visible_from', '<=', now())->where('visible_to', '>=', now())->get();

// After
Post::whereValueBetween(now(), ['visible_from', 'visible_to'])->get();

The methods added are:

• whereValueBetween()
• orWhereValueBetween()
• whereValueNotBetween()
• orWhereValueNotBetween()

The only consideration is that the BETWEEN clause is inclusive (given SQL Standards), which is also used on the other between methods.

[shaedrich]

Would it make sense to have a flag to allow for exclusive and half-open BETWEENs?

[DarkGhostHunter]

Would it make sense to have a flag to allow for exclusive and half-open BETWEENs?

What do you mean? AFAIK, BETWEEN is inclusive and doesn't have flags for exclusivity, let alone more than two values/columns.

Anyway, let's see if this basic implementation is accepted first and then we can talk about adding more.