Skip to content

Conversation

xiCO2k
Copy link
Member

@xiCO2k xiCO2k commented Mar 30, 2022

This PR fixes #1023

Removes the addition of Ziggy on the ShareInertiaData middleware, and only add Ziggy to the HandleInertiaData stub if --ssr is passed, so that way if anyone wants to remove, they have the full control.

Thanks,
Francisco

@xiCO2k xiCO2k changed the title [2.x] Not requiring Ziggy on ShareInertiaData middleware. [2.x] Not require Ziggy on ShareInertiaData middleware. Mar 30, 2022
@taylorotwell
Copy link
Member

@xiCO2k how will this middleware actually be invoked? where is it registered with the routes?

@xiCO2k
Copy link
Member Author

xiCO2k commented Mar 30, 2022

Yes, the middleware is already added here:

$this->installMiddlewareAfter('SubstituteBindings::class', '\App\Http\Middleware\HandleInertiaRequests::class');

@taylorotwell taylorotwell merged commit 2c3c9c5 into laravel:2.x Mar 30, 2022
@xiCO2k xiCO2k deleted the fix/requirement-ziggy branch March 30, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ziggy is no longer optional

2 participants