Skip to content

Test Improvements #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 19, 2023
Merged

Test Improvements #1380

merged 6 commits into from
Sep 19, 2023
+75 −207

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Sep 19, 2023 •
edited
Loading

  • use protected function setUp()
  • set default database connection to testing (SQLite in-memory db)
  • use LazilyRefreshDatabase to avoid calling artisan('migrate') on every tests.

@crynobone
Test Improvements
aee9607 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
f0a323e 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
cf6e0f7 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
73764cb 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone crynobone marked this pull request as ready for review September 19, 2023 08:51
@crynobone
wip
492ca2c 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
45a40b6 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@taylorotwell taylorotwell merged commit 793b3d8 into 4.x Sep 19, 2023
@taylorotwell taylorotwell deleted the test-improvements branch September 19, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crynobone @taylorotwell