-
Notifications
You must be signed in to change notification settings - Fork 170
[1.x] Makes Pint 40x faster #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nunomaduro 2 minutes for 2000 files makes me wonder if you had XDEBUG_MODE set to something other than off. Because setting it to off gives me >10x performance. Would you consider doing that automatically in Pint? Lots of developers have it set to debug,develop by default, and might not know that it should be turned off when running Pint. |
Thanks. |
Congrats for making Pint faster, but to be honest any reference to PHP-CS-Fixer/PHP-CS-Fixer#7777 or credits for me for actual work on parallel runner would be really welcome, though |
this pull request adds the --parallel option to laravel pint, enabling it to fully leverage the parallel capabilities of php cs fixer. the results are just insane:
this feature has actually been in php cs fixer for a while — we just hadn’t been using it until now. 🤷🏻♂️
finally, this new feature should be considered experimental and potentially unstable. therefore, i’ve added the experimental wording to the optional flag
--parallel
, so people can try it out in the meantime.