-
Notifications
You must be signed in to change notification settings - Fork 323
Support git_remote_create_with_opts #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support git_remote_create_with_opts #733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks for doing this!
- Use consistent names for type/function names. - Removes unnecessary Repository pointers that can be collected from RemoteCollection. - Add runtime.KeepAlive to make the pointer happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few more style requests and we're good!
…xOptions. Also, handling the return code of libgit2 has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :D
Closes #645 (cherry picked from commit 73d97b9) Co-authored-by: Byoungchan Lee <[email protected]>
* Support git_remote_create_with_opts (#733) Closes #645 (cherry picked from commit 73d97b9) Co-authored-by: Byoungchan Lee <[email protected]>
Closes #645