Skip to content

Support git_remote_create_with_opts #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Support git_remote_create_with_opts #733

merged 4 commits into from
Feb 4, 2021

Conversation

bc-lee
Copy link
Contributor

@bc-lee bc-lee commented Feb 1, 2021

Closes #645

Copy link
Contributor

@lhchavez lhchavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for doing this!

- Use consistent names for type/function names.
- Removes unnecessary Repository pointers that can be collected from
  RemoteCollection.
- Add runtime.KeepAlive to make the pointer happy.
Copy link
Contributor

@lhchavez lhchavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few more style requests and we're good!

…xOptions.

Also, handling the return code of libgit2 has changed.
Copy link
Contributor

@lhchavez lhchavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :D

@lhchavez lhchavez merged commit 73d97b9 into libgit2:master Feb 4, 2021
github-actions bot pushed a commit that referenced this pull request Feb 4, 2021
Closes #645

(cherry picked from commit 73d97b9)
github-actions bot pushed a commit that referenced this pull request Feb 4, 2021
Closes #645

(cherry picked from commit 73d97b9)
github-actions bot pushed a commit that referenced this pull request Feb 4, 2021
Closes #645

(cherry picked from commit 73d97b9)
@bc-lee bc-lee deleted the feature/645-git-remote-create-with-opts branch February 4, 2021 05:24
lhchavez pushed a commit that referenced this pull request Feb 6, 2021
Closes #645

(cherry picked from commit 73d97b9)

Co-authored-by: Byoungchan Lee <[email protected]>
lhchavez pushed a commit that referenced this pull request Feb 6, 2021
* Support git_remote_create_with_opts (#733)

Closes #645

(cherry picked from commit 73d97b9)
Co-authored-by: Byoungchan Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support git_remote_create_with_opts
2 participants