Skip to content

fix: scope logging to connection and stream #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 9, 2025
Merged

fix: scope logging to connection and stream #3215

merged 7 commits into from
Jul 9, 2025

Conversation

achingbrain
Copy link
Member

Updates log scope for streams to use the muxer scope, which uses the connection scope so we can trace log lines per stream/connection instead of having component scope.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: scope logging to connection and stream
8e3720a 
Updates log scope for streams to use the muxer scope, which uses
the connection scope so we can trace log lines per stream/connection
instead of having component scope.
@achingbrain achingbrain requested a review from a team as a code owner July 9, 2025 10:11
@achingbrain achingbrain merged commit ce6b542 into main Jul 9, 2025
59 of 64 checks passed
@achingbrain achingbrain deleted the feat/scope-logging-to-connection-and-stream branch July 9, 2025 15:06
@achingbrain
Copy link
Member Author

Refs: ipshipyard/roadmaps#22

@achingbrain achingbrain mentioned this pull request Jul 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain