kvdb/sqlite: enable incremental auto_vacuum on DB creation #9672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
requested review from
a team,
Copilot,
bhandras and
bitromortac
and removed request for
a team
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR enables incremental auto_vacuum for newly created SQLite databases by setting the corresponding SQLite pragma during database creation.
- Updated NewSqliteBackend to include a new isCreate boolean parameter.
- Modified createDBDriver and openDBDriver to pass appropriate values for isCreate.
- Refactored internal representation of pragma options to use the named struct pragmaOption.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kvdb/sqlite/driver.go | Updated function calls to NewSqliteBackend with a new boolean flag. |
| kvdb/sqlite/db.go | Modified NewSqliteBackend signature and added auto_vacuum logic using pragmaOption. |
ziggie1984
reviewed
Apr 2, 2025
Roasbeef
force-pushed
the
kvdb-sqlite-incremental-vacuum
branch
from
a28b432 to
faba39f
Compare
bhandras
reviewed
Apr 3, 2025
kvdb/sqlite/driver.go
Outdated
| // is meant to open existing databases, but the underlying driver might | ||
| // create one if it doesn't exist. We need to know if we are creating | ||
| // it here to set the initial pragmas correctly (like auto_vacuum). | ||
| fullPath := filepath.Join(dbPath, filename) |
There was a problem hiding this comment.
We'll need to do the same thing for sqldb.NewSqliteStore(...)
Line 52 in 6a3845b
There was a problem hiding this comment.
Ah good catch. Added in the latest commit.
bhandras
reviewed
Apr 3, 2025
ellemouton
reviewed
Apr 3, 2025
|
Added the temp replace. |
Roasbeef
force-pushed
the
kvdb-sqlite-incremental-vacuum
branch
from
319d881 to
ec02bb0
Compare
|
Please note that the sqlite unit tests are failing now. |
ellemouton
reviewed
Apr 4, 2025
Roasbeef
force-pushed
the
kvdb-sqlite-incremental-vacuum
branch
from
ec02bb0 to
29a9f4e
Compare
In this commit, we make a change that enables the `auto_vacuum = incremental` pragma for SQLite databases, but only when the database file is first created. Incremental auto-vacuum allows SQLite to reclaim unused space within the database file over time, preventing indefinite growth.
Roasbeef
force-pushed
the
kvdb-sqlite-incremental-vacuum
branch
from
29a9f4e to
9eef2a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we make a change that enables the
auto_vacuum = incrementalpragma for SQLite databases, but only when the database file is first created. Incremental auto-vacuum allows SQLite to reclaim unused space within the database file over time, preventing indefinite growth.According to the SQLite documentation, the
auto_vacuummode must be set before any tables are created in the database. To achieve this, a new boolean parameterisCreatehas been added to theNewSqliteBackendfunction.The
createDBDrivernow passestruefor this parameter, ensuring the pragma is set during initial database setup. Conversely,openDBDriverpassesfalsewhen opening an existing database, leaving the existing vacuum mode untouched.We also change, the internal representation of pragma options was refactored to use a named struct
pragmaOptionfor improved clarity.